Remove obsolete functions in _nsis.py
#1068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
3 tasks
jaimergp
approved these changes
Oct 2, 2025
Contributor
jaimergp
left a comment
jaimergp
left a comment
There was a problem hiding this comment.
LGTM. Can you add PR comments pointing to their replacement counterparts, if they exist? The menuinst ones did have deprecation messaegs, but win_del and others are not so clear.
Contributor
Author
I updated the PR description. From what I can see, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused subcommands and functions in
_nsis.py. This is part of the effort to remove the cross-bundling betweenconstructorandconda-standalone, and remove dependencies onpython(#549).There are three main subcommands that are not used anymore:
mkmenusandrmmenushave been replaced bymenuinst.delappears to be a wrapper around theRDcommand.RMDIRis called directly in NSIS.The remaining functions are only needed by the removed subcommands.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?