-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build .conda
artifacts by default
#5527
base: main
Are you sure you want to change the base?
Conversation
Thanks Jaime! 🙏 |
CodSpeed Performance ReportMerging #5527 will not alter performanceComparing Summary
|
It looks like there is a similar/related issue that was filed here previously: #4890 There's currently an open PR that addresses this issue by creating a new command line argument |
Thanks Bianca! 🙏 Think these are different changes This change is making the default package type That change is allowing users to specify the package type via CLI These are both good changes. They just serve different purposes. Ideally we get them both in With this change, we are thinking of having a deprecation (or future) warning in 24.11 to note the default would change in 25.1. Then include this change after the 24.11 branch (or tag) |
Yea maybe #5209 should go in first (that refactor is useful here too). It's also a good opportunity to add a warning there about the future change in e.g. 25.1. In other words: For 24.11:
For 25.1:
|
I agree with that timeline, just reviewed #5209 |
Description
Closes #5183
Checklist - did you ...
news
directory (using the template) for the next release's release notes?