Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build .conda artifacts by default #5527

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Nov 6, 2024

Description

Closes #5183

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 6, 2024
@jakirkham
Copy link
Member

Thanks Jaime! 🙏

Copy link

codspeed-hq bot commented Nov 6, 2024

CodSpeed Performance Report

Merging #5527 will not alter performance

Comparing jaimergp:default-dot-conda (74ed076) with main (1341886)

Summary

✅ 5 untouched benchmarks

@beeankha
Copy link
Member

beeankha commented Nov 6, 2024

It looks like there is a similar/related issue that was filed here previously: #4890

There's currently an open PR that addresses this issue by creating a new command line argument --package-format and may potentially be the option we want to go with to include in the November 2024 conda-build release. @jaimergp @jakirkham please let me know your thoughts on this.

@jakirkham
Copy link
Member

Thanks Bianca! 🙏

Think these are different changes

This change is making the default package type .conda (instead of .tar.bz2) as requested in issue: #5183

That change is allowing users to specify the package type via CLI

These are both good changes. They just serve different purposes. Ideally we get them both in

With this change, we are thinking of having a deprecation (or future) warning in 24.11 to note the default would change in 25.1. Then include this change after the 24.11 branch (or tag)

@jaimergp
Copy link
Contributor Author

jaimergp commented Nov 7, 2024

Yea maybe #5209 should go in first (that refactor is useful here too). It's also a good opportunity to add a warning there about the future change in e.g. 25.1. In other words:

For 24.11:

For 25.1:

  • Rebase this PR and flip the default. Some tests need adjustment.

@jezdez
Copy link
Member

jezdez commented Nov 7, 2024

Yea maybe #5209 should go in first (that refactor is useful here too). It's also a good opportunity to add a warning there about the future change in e.g. 25.1. In other words:

For 24.11:

  • Review and merge Issue/4890 #5209
  • A new PR adds a warning about the change of the default in 25.1

For 25.1:

  • Rebase this PR and flip the default. Some tests need adjustment.

I agree with that timeline, just reviewed #5209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Make .conda the default format for future conda-build versions
5 participants