Update to v2.2.28 #45
Conversation
xylar
requested review from
DPeterK,
kwilcox,
ocefpaf,
pelson and
zklaus
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
To do this, we need to change the source location.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/udunits2-feedstock/actions/runs/1786519468. |
recipe/meta.yaml
Outdated
|
|
||
| package: | ||
| name: udunits2 | ||
| version: {{ version }} | ||
|
|
||
| source: | ||
| url: https://github.com/Unidata/UDUNITS-2/archive/v{{ version }}.tar.gz | ||
| sha256: 6c65b3097ef38b94c01dfede8904346c1439de9704b9bae7deea72bd5143a7bb | ||
| url: https://artifacts.unidata.ucar.edu/repository/downloads-udunits/{{ version }}/udunits-{{ version }}.tar.gz |
There was a problem hiding this comment.
@conda-forge/udunits2, it seems that the 2.2.28 tag was never created on GitHub. Thus the change in location for the source. We can change back if tagging happens as expected for future releases. See:
Unidata/UDUNITS-2#104
and
Unidata/UDUNITS-2#109
There was a problem hiding this comment.
I would consider the new location to be the canonical location.
There was a problem hiding this comment.
Hopefully, the bot will understand it well enough to notice new releases.
| url: https://artifacts.unidata.ucar.edu/repository/downloads-udunits/{{ version }}/udunits-{{ version }}.tar.gz # [not win] | ||
| sha256: 590baec83161a3fd62c00efa66f6113cec8a7c461e3f61a5182167e0cc5d579e # [not win] | ||
| url: https://artifacts.unidata.ucar.edu/repository/downloads-udunits/{{ version }}/udunits-{{ version }}.zip # [win] | ||
| sha256: e09d31db68f9a840a0663c7e9909101957733ff0310761b9906f4722e0d92c44 # [win] |
There was a problem hiding this comment.
There appear to have been some pretty significant packaging problems in which necessary files for CMake were included in the .zip file but not in the .tar.gz file. Hopefully, this selector is only necessary for this one build. See Unidata/UDUNITS-2#108 for more on this.
|
@conda-forge/udunits2, this is ready to review. Feel free to merge it, I just want another pair of eyes on it. |
To do this, we need to change the source location.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)closes #44