Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for 3dSlicer (https://github.com/Slicer/Slicer) #28807

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martin-g
Copy link

@martin-g martin-g commented Jan 10, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 10, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/3dslicer/meta.yaml) and found some lint.

Here's what I've got...

For recipes/3dslicer/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • ❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

For recipes/3dslicer/meta.yaml:

  • ℹ️ The use of xz is deprecated. If your package links to liblzma, use the new liblzma-devel package. For XZ's command line utilities (like xz and unxz), use the xz-toolspackage. For the xz-enabled GNU tools (like grep), use xz-gpl-tools. Note: Command line utilities should go in requirements/build.
  • ℹ️ The boost output has been superseded by libboost-python-devel (as of 1.82), which now comes with a run-export (on libboost-python) as well.
  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12711219524. Examine the logs at this URL for more detail.

@martin-g martin-g force-pushed the 3dslicer branch 2 times, most recently from 23d52df to 455101d Compare January 10, 2025 13:42
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants