Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding primp from PyPI #28780

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Adding primp from PyPI #28780

wants to merge 11 commits into from

Conversation

sugatoray
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 7, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/primp/meta.yaml) and found some lint.

Here's what I've got...

For recipes/primp/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12657447793. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/primp/meta.yaml) and found it was in an excellent condition.

@sugatoray
Copy link
Contributor Author

PR is ready. Request for review/merging.

cc: @conda-forge/help-python @ocefpaf

@sugatoray sugatoray changed the title Adding primp from PyPI Adding primp and duckduckg-search from PyPI Jan 7, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/duckduckgo-search/meta.yaml, recipes/primp/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/duckduckgo-search/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12657697328. Examine the logs at this URL for more detail.

@sugatoray sugatoray changed the title Adding primp and duckduckg-search from PyPI Adding primp from PyPI Jan 7, 2025
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/primp/meta.yaml) and found it was in an excellent condition.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 8, 2025

cc: @conda-forge/help-python @ocefpaf

I'm part of that team. No need to ping me twice.

@sugatoray
Copy link
Contributor Author

cc: @conda-forge/help-python @ocefpaf

I'm part of that team. No need to ping me twice.

Thank you.

recipes/primp/meta.yaml Outdated Show resolved Hide resolved
recipes/primp/meta.yaml Outdated Show resolved Hide resolved
recipes/primp/meta.yaml Outdated Show resolved Hide resolved
recipes/primp/meta.yaml Outdated Show resolved Hide resolved
- python {{ python_min }}
- pip
- setuptools
- wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unlikely that this requires wheel at host.

Suggested change
- wheel

recipes/primp/meta.yaml Outdated Show resolved Hide resolved
recipes/primp/meta.yaml Outdated Show resolved Hide resolved
recipes/primp/meta.yaml Outdated Show resolved Hide resolved
recipes/primp/meta.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants