-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TidalPy #28771
base: main
Are you sure you want to change the base?
Add TidalPy #28771
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/TidalPy/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12664111490. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/TidalPy/meta.yaml:
For recipes/TidalPy/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12664348873. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/TidalPy/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12664382061. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hey @conda-forge/help-python-c, I think we are ready for the next step here. Thanks!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
numpy should be pinned differently
Thank you! |
Co-authored-by: Uwe L. Korn <[email protected]>
Co-authored-by: Uwe L. Korn <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/TidalPy/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13887750339. Examine the logs at this URL for more detail. |
- astropy-base | ||
- astroquery | ||
- matplotlib-base >=3.4.2 | ||
- ipympl >=0.9.6, <0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ipympl >=0.9.6, <0.10.0 | |
- ipympl >=0.9.6,<0.10.0 |
- dill >=0.3.2 | ||
- psutil >=5.8.0 | ||
- pathos >=0.2.0 | ||
- cyrk >=0.12.1,<0.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason this package is not building is because your other package cyrk is not pinning numpy correctly.
When you specify a specific pinning for a package, it overides our channel pinnings and floats up to the newest compatible version in the pinning. We pin different numpy versions for each python version channel-wide to improve compatability amongst packages, but since cyrk overrides this pinning, it has been built with numpy 1.26 for all python versions. This makes it incompatible with our channel pinnings which specify numpy 1.22 for python 3.9.
If you want to enforce both your pinnings and our channel pinnings at the same time, you need to specify the package twice. For example:
- numpy # empty version spec will pick up channel pinnings
- numpy >=1.22,<2 # your pinnings also enforced
CC: @ocefpaf because you reviewed and merged the feedstock for cyrk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should fix it in the other package feedstock.
Opening this PR for the
TidalPy
python package which has components written in Cython. Tests are passing on various systems via GitHub actions. We will see if they pass in conda-forge's CI!Thanks for all you do.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).