Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TidalPy #28771

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add TidalPy #28771

wants to merge 13 commits into from

Conversation

jrenaud90
Copy link
Contributor

@jrenaud90 jrenaud90 commented Jan 6, 2025

Opening this PR for the TidalPy python package which has components written in Cython. Tests are passing on various systems via GitHub actions. We will see if they pass in conda-forge's CI!

Thanks for all you do.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 6, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/TidalPy/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/TidalPy/meta.yaml:

  • ℹ️ Recipes should usually depend on astropy-base as opposed to astropy. astropy-base only has the required dependancies whereas astropy now has all optional dependancies as well.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12664111490. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 8, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/TidalPy/meta.yaml) and found some lint.

Here's what I've got...

For recipes/TidalPy/meta.yaml:

  • requirements: run: ipympl>=0.9.6, <0.10.0 must contain a space between the name and the pin, i.e. ipympl >=0.9.6,<0.10.0

For recipes/TidalPy/meta.yaml:

  • ℹ️ Recipes should usually depend on astropy-base as opposed to astropy. astropy-base only has the required dependancies whereas astropy now has all optional dependancies as well.
  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12664348873. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/TidalPy/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/TidalPy/meta.yaml:

  • ℹ️ Recipes should usually depend on astropy-base as opposed to astropy. astropy-base only has the required dependancies whereas astropy now has all optional dependancies as well.
  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12664382061. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/TidalPy/meta.yaml) and found it was in an excellent condition.

@jrenaud90
Copy link
Contributor Author

Hey @conda-forge/help-python-c, I think we are ready for the next step here. Thanks!!

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numpy should be pinned differently

@jrenaud90
Copy link
Contributor Author

numpy should be pinned differently

Thank you!

jrenaud90 and others added 2 commits January 11, 2025 15:46
@jrenaud90 jrenaud90 requested a review from xhochy January 11, 2025 20:47
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Mar 16, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/TidalPy/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/TidalPy/meta.yaml:

  • ℹ️ top-level output has some malformed specs:
  • In section run: ipympl >=0.9.6, <0.10.0 Requirement spec fields should always be space-separated to avoid known issues in conda-build. For example, instead of name =version=build, use name version.* build`.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13887750339. Examine the logs at this URL for more detail.

- astropy-base
- astroquery
- matplotlib-base >=3.4.2
- ipympl >=0.9.6, <0.10.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ipympl >=0.9.6, <0.10.0
- ipympl >=0.9.6,<0.10.0

- dill >=0.3.2
- psutil >=5.8.0
- pathos >=0.2.0
- cyrk >=0.12.1,<0.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason this package is not building is because your other package cyrk is not pinning numpy correctly.

When you specify a specific pinning for a package, it overides our channel pinnings and floats up to the newest compatible version in the pinning. We pin different numpy versions for each python version channel-wide to improve compatability amongst packages, but since cyrk overrides this pinning, it has been built with numpy 1.26 for all python versions. This makes it incompatible with our channel pinnings which specify numpy 1.22 for python 3.9.

If you want to enforce both your pinnings and our channel pinnings at the same time, you need to specify the package twice. For example:

  - numpy  # empty version spec will pick up channel pinnings
  - numpy >=1.22,<2  # your pinnings also enforced

CC: @ocefpaf because you reviewed and merged the feedstock for cyrk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should fix it in the other package feedstock.

@carterbox carterbox requested a review from ocefpaf March 16, 2025 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants