Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libabigail #27607

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Add libabigail #27607

merged 3 commits into from
Sep 20, 2024

Conversation

calebzulawski
Copy link
Contributor

@calebzulawski calebzulawski commented Sep 17, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libabigail/meta.yaml) and found some lint.

Here's what I've got...

For recipes/libabigail/meta.yaml:

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libabigail/meta.yaml) and found it was in an excellent condition.

@calebzulawski
Copy link
Contributor Author

@conda-forge/help-c-cpp, ready for review!

- libxml2

test:
commands:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this also contain some libraries one links to? Please check for their existence here and add a run_exports.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you're right, I didn't know about this field. The library number changes every minor release, so I think I added this correctly...

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@xhochy xhochy merged commit f9a0655 into conda-forge:main Sep 20, 2024
6 checks passed
@calebzulawski calebzulawski deleted the abigail branch September 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants