Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flint, git-hound, lefthook #27587

Merged
merged 18 commits into from
Sep 20, 2024
Merged

Conversation

danielnachun
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flint/meta.yaml, recipes/git-hound/meta.yaml, recipes/lefthook/meta.yaml, recipes/spr/meta.yaml) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flint/meta.yaml, recipes/git-hound/meta.yaml, recipes/lefthook/meta.yaml) and found it was in an excellent condition.

@danielnachun
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-go This is now ready for review.

Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@danielnachun danielnachun changed the title add flint, git-hound, lefthook, spr add flint, git-hound, lefthook Sep 14, 2024
@@ -0,0 +1,35 @@
{% set name = "flint" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a different name we could use. There are multiple projects that use this name. We also already have a libflint package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed it to flint-checker, which has been used by other package managers to avoid this exact issue with name conflicts.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/flint-checker/meta.yaml, recipes/git-hound/meta.yaml, recipes/lefthook/meta.yaml) and found it was in an excellent condition.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@xhochy xhochy merged commit 300addb into conda-forge:main Sep 20, 2024
6 checks passed
@danielnachun danielnachun deleted the git-tools2 branch October 6, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants