Skip to content

Commit

Permalink
test skip hyghiene: remove skips for tests that now pass
Browse files Browse the repository at this point in the history
  • Loading branch information
h-vetinari committed Aug 26, 2024
1 parent dd04dcb commit 6ef073c
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -287,10 +287,8 @@ outputs:
{% set tests_to_skip = tests_to_skip + " or test_debug_memory_pool_disabled" %} # [aarch64 or ppc64le]
{% set tests_to_skip = tests_to_skip + " or test_env_var_io_thread_count" %} # [aarch64 or ppc64le]
# vvvvvvv TESTS THAT SHOULDN'T HAVE TO BE SKIPPED vvvvvvv
# problems with minio
{% set tests_to_skip = tests_to_skip + " or (test_delete_dir and S3FileSystem)" %}
{% set tests_to_skip = tests_to_skip + " or (test_get_file_info and S3FileSystem)" %}
{% set tests_to_skip = tests_to_skip + " or (test_move_directory and S3FileSystem)" %}
# https://github.com/apache/arrow/issues/43800
{% set tests_to_skip = tests_to_skip + " or test_cpp_extension_in_python" %} # [osx]
# XMinioInvalidObjectName on win: "Object name contains unsupported characters"
{% set tests_to_skip = tests_to_skip + " or test_write_to_dataset_with_partitions_s3fs" %} # [win]
# https://github.com/apache/arrow/issues/43356
Expand All @@ -302,9 +300,6 @@ outputs:
{% set tests_to_skip = tests_to_skip + " or test_feather_format[serial]" %} # [aarch64]
# gandiva tests are segfaulting on ppc
{% set tests_to_skip = tests_to_skip + " or test_gandiva" %} # [ppc64le]
# test failures on ppc (both failing with: Float value was truncated converting to int32)
{% set tests_to_skip = tests_to_skip + " or test_safe_cast_from_float_with_nans_to_int" %} # [ppc64le]
{% set tests_to_skip = tests_to_skip + " or test_float_with_null_as_integer" %} # [ppc64le]
# ^^^^^^^ TESTS THAT SHOULDN'T HAVE TO BE SKIPPED ^^^^^^^
- pytest pyarrow/ -rfEs -k "not ({{ tests_to_skip }})"

Expand Down

0 comments on commit 6ef073c

Please sign in to comment.