Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-c v0.9.32 #13

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #10

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: disabled to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8949941769 - please use this URL for debugging.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@carterbox
Copy link
Member

See previous PR for fixes to these problems.

@hmaarrfk
Copy link
Contributor

hmaarrfk commented May 5, 2024

Thansk i pulled in the patches and am trying to build with libgit2 1.8

@carterbox
Copy link
Member

carterbox commented May 5, 2024

It looks like the pkgconfig for the rust package libgit2-sys v0.16.2+1.7.2 is setup to specifically check for libgit2 >=1.7,<1.8, so it will not build with later versions.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=927609&view=logs&j=4f922444-fdfe-5dcf-b824-02f86439ef14&t=937c195f-508d-5135-dc9f-d4b5730df0f7&l=1329

@carterbox
Copy link
Member

We should just wait until upstream supports libgit2>=1.8 unless there are some serious bug fixes that these two patch releases provide.

@carterbox
Copy link
Member

Waiting on rust-lang/git2-rs#1032, so that we can build with libgit 1.8 since the channel has already migrated to libgit 1.8?

The pinnings on the libgit2 feestock are to the minor version, but do we know actual ABI compatability? If 1.7 and 1.8 are ABI compatible, then it shouldn't matter which version we build against.

@hmaarrfk
Copy link
Contributor

I have not checked abi compatibility

@carterbox
Copy link
Member

https://abi-laboratory.pro/index.php?view=timeline&l=libgit2

The abilab history ends with 1.0.1, but I can build later versions and see what's up.

@carterbox
Copy link
Member

Don't need to build it. The developers of libgit2 are very transparent about ABI/API breaking changes in their release notes which we can read on their github page. They in recent times they have been breaking the ABI with minor releases, so the run_exports are validly pinned to minor releases.

https://github.com/libgit2/libgit2/releases

In an issue they mention that they may start to stabilize / correlate the ABI with the SO name in version 2.0.

libgit2/libgit2#5670

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Jun 18, 2024
3 tasks
@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Jun 27, 2024
3 tasks
@carterbox carterbox added the wontfix This will not be worked on label Jun 27, 2024
@carterbox carterbox closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants