-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-c v0.9.32 #13
cargo-c v0.9.32 #13
Conversation
…nda-forge-pinning 2024.05.04.08.17.47
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
See previous PR for fixes to these problems. |
Thansk i pulled in the patches and am trying to build with libgit2 1.8 |
It looks like the pkgconfig for the rust package libgit2-sys v0.16.2+1.7.2 is setup to specifically check for libgit2 >=1.7,<1.8, so it will not build with later versions. |
We should just wait until upstream supports libgit2>=1.8 unless there are some serious bug fixes that these two patch releases provide. |
Waiting on rust-lang/git2-rs#1032, so that we can build with libgit 1.8 since the channel has already migrated to libgit 1.8? The pinnings on the libgit2 feestock are to the minor version, but do we know actual ABI compatability? If 1.7 and 1.8 are ABI compatible, then it shouldn't matter which version we build against. |
I have not checked abi compatibility |
https://abi-laboratory.pro/index.php?view=timeline&l=libgit2 The abilab history ends with 1.0.1, but I can build later versions and see what's up. |
Don't need to build it. The developers of libgit2 are very transparent about ABI/API breaking changes in their release notes which we can read on their github page. They in recent times they have been breaking the ABI with minor releases, so the run_exports are validly pinned to minor releases. https://github.com/libgit2/libgit2/releases In an issue they mention that they may start to stabilize / correlate the ABI with the SO name in version 2.0. |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
@conda-forge-admin,
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun bot
in a PR comment to have theconda-forge-admin
add it for you.Closes: #10
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: disabled
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8949941769 - please use this URL for debugging.