Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Detect changes correctly in conandata and conanfile #244

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jun 20, 2024

Some more fixes:

  • Correct logic for overwritting guarded files
  • Don't crash when reading conandata if the file is modified with unknown keys
  • Remove the guard comment, and it shows empty lists.
  • Remove a requirement from the conandata and click the "list only installed" button; it still shows the removed one.
  • Remove the guard comment, click the add requirement button on any reference, and the pop-up window shows that it has been added, but in reality, it hasn't (this last part is expected; what you don't expect is the pop-up window).

Closes: #242

@czoido czoido requested review from AbrilRBS and danimtb June 20, 2024 16:03
@czoido czoido added this to the 2.0.6 milestone Jun 20, 2024
@czoido czoido merged commit d081863 into develop2 Jun 24, 2024
3 checks passed
@czoido czoido deleted the fix-changes-detected branch June 24, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Extension not detecting changes in conanfile.py
2 participants