Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix CI for artifactory tests colliding in parallel run #151

Merged
merged 13 commits into from
Aug 23, 2024
Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Aug 22, 2024

There is currently an issue in the CI for tests that require interacting with Artifactory, as it happened at #150.
Those tests are run in parallel and sometimes they interfere, causing the CI to fail.

This PRs makes those tests run sequentially (unfortunately I did not find a more elegant way to achieve that 😓)

@danimtb danimtb changed the title test CI Fix: Fix CI for artifactory tests colliding in parallel run Aug 22, 2024
@danimtb danimtb marked this pull request as ready for review August 22, 2024 14:01
@danimtb danimtb requested review from czoido and AbrilRBS and removed request for czoido August 23, 2024 07:19
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice catch!
But as far as I can tell, isn't this a plugin that would need to be installed first? https://pytest-dev.github.io/pytest-order/stable/intro.html

@danimtb
Copy link
Member Author

danimtb commented Aug 23, 2024

Oh, nice catch! But as far as I can tell, isn't this a plugin that would need to be installed first? https://pytest-dev.github.io/pytest-order/stable/intro.html

Yes, you are right. I also checked it beforehand but it seemed to work in my machine and also in the CI. Anyway, I will add it to the pip install call and try to remove some of the warnings in the output as well. Thanks!

@danimtb danimtb self-assigned this Aug 23, 2024
@danimtb danimtb merged commit d95a00e into main Aug 23, 2024
3 checks passed
danimtb added a commit that referenced this pull request Aug 26, 2024
czoido pushed a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants