Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bzip2: generate a relocatable shared lib on macOS #9054

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 24, 2022

Specify library name and version: lib/1.0

see conan-io/hooks#376


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 24, 2022

Now bzip2 shared in install tree is relocatable:

otool -L libbz2.1.0.8.dylib

libbz2.1.0.8.dylib:
	@rpath/libbz2.1.dylib (compatibility version 1.0.0, current version 1.0.8)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.0.0)

without this fix, it's wrong:

libbz2.1.0.8.dylib:
	libbz2.1.dylib (compatibility version 1.0.0, current version 1.0.8)
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.0.0)

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 2 (0bfe19fbd6da72e234a44d7c5f4b046396efb3ea):

  • bzip2/1.0.8@:
    All packages built successfully! (All logs)

  • bzip2/1.0.6@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 3c6672c into conan-io:master Feb 2, 2022
@SpaceIm SpaceIm deleted the fix/bzip2-relocatable branch February 2, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants