Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitsery: add version 5.2.1 #3609

Closed
wants to merge 1 commit into from

Conversation

qchateau
Copy link
Contributor

Generated and committed by conan-center-bot

Specify library name and version: bitsery/5.2.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

I've modified the bot following your latest comments, and it now tried to keep the yaml format untouched. Also, the issue at #3470 now generates the updates in branches of my fork and you can open PR (such as this one) in one click from the issue if there are no errors with the updated recipe.

Generated and committed by [conan-center-bot](https://github.com/qchateau/conan-center-bot)
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@conan-center-bot conan-center-bot added the Bump version PR bumping version without recipe modifications label Nov 19, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 1 (4b726482261326965c5f862f1fb86e1c2657bd10)! 😊

@SpaceIm
Copy link
Contributor

SpaceIm commented Nov 19, 2020

versions are unordered in yml files

@qchateau
Copy link
Contributor Author

some do it ascending, some do it descending

You're saying it does not matter but it should always be ordered ?

@qchateau
Copy link
Contributor Author

By the way, what's up with the CLA bot ? Is it because the commit is from "actions-user" ?

@madebr
Copy link
Contributor

madebr commented Nov 19, 2020

Looks like it. It's all about accountability.
Nice idea btw, but alas CLA bot is spoiling the fun (currently).
Maybe also drop a line in conan-center-bot's license that the patches it generates are license-free/MIT?

Idea:
Let your python package conan-center-bot run by @conan-center-bot.
And make sure that commits by @conan-center-bot are accepted by CLA.

@qchateau
Copy link
Contributor Author

It's actually pretty simple, I just need to configure git in the github action that creates the commit to use my email address. Which kind of makes sense.

I'll close this PR, and re-generate the branch with the right commit in the next few days

@qchateau qchateau closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump version PR bumping version without recipe modifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants