fix: require creating a payment channel before depositing

comrade-coop · Dec 26, 2023 · 0ae5768 · 0ae5768
1 parent 145d6da
commit 0ae5768
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/contracts/src/Payment.sol b/contracts/src/Payment.sol
@@ -62,6 +62,8 @@ contract Payment {
         address publisher = msg.sender;
         Channel storage channel = channels[publisher][provider][podId];
 
+        if (channel.investedByPublisher == 0) revert DoesNotExist();
+
         channel.investedByPublisher = channel.investedByPublisher + amount;
         channel.unlockedAt = 0;
 

diff --git a/contracts/test/Payment.t.sol b/contracts/test/Payment.t.sol
@@ -45,6 +45,9 @@ contract PaymentTest is Test {
         token.mint(1000);
 
         token.approve(address(payment), 500);
+        vm.expectRevert(Payment.DoesNotExist.selector);
+        payment.deposit(provider, podId, 500);
+
         payment.createChannel(provider, podId, 1, 500);
 
         token.approve(address(payment), 500);