[cmake] update JSObjects CMake minimum version to 3.10#202
Merged
compnerd merged 1 commit intocompnerd:mainfrom Apr 7, 2025
Merged
[cmake] update JSObjects CMake minimum version to 3.10#202compnerd merged 1 commit intocompnerd:mainfrom
compnerd merged 1 commit intocompnerd:mainfrom
Conversation
compnerd
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the min required CMake version for JSObjects to 3.10. This avoids errors and warnings when building with CMake versions >= 4.0 which no longer support syntax < version 3.5 and warn on < version 3.10.
I observed these failures a few time in nightly runs, but they are not consistent. It seems like some of the GitHub runners have newer CMake versions.
https://github.com/andrurogerz/ds2/actions/runs/14258245061/job/39964714091
https://github.com/andrurogerz/ds2/actions/runs/14235199194/job/39893148054
https://github.com/andrurogerz/ds2/actions/runs/14211762613/job/39820138528