src: Use errorOccurred instead of error signal #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please follow the existing commits message layout. |
Nerixyz
force-pushed
the
fix/error-occurred
branch
from
b3d7ac3 to
d9e4e12
Compare
Nerixyz
changed the title
QAbstractSocket::errorOccurred Signal over error in Qt 5.15 and Up
I updated it. |
Thaodan
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QAbstractSocket::errorOccurredsignal was marked as obsolete in Qt 5.15, and removed in Qt 6. TheQAbstractSocket::errorOccurredsignal should be used instead.This PR adds a check that uses the new signal if the Qt version is 5.15 and up.