Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Qqwy as maintainer of 'vary' #7672

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

Qqwy
Copy link
Contributor

@Qqwy Qqwy commented Feb 5, 2025

Checklist:

  • Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • At least 30 minutes have passed since uploading to Hackage
  • If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@Qqwy Qqwy force-pushed the patch-2 branch 2 times, most recently from 87504cd to 132e627 Compare February 5, 2025 08:25
@Qqwy Qqwy changed the title Adding myself as maintainer of 'vary' and 'symbolize'; Update build-c… Adding Qqwy as maintainer of 'vary' and 'symbolize' Feb 5, 2025
@alaendle
Copy link
Member

alaendle commented Feb 6, 2025

Thanks @Qqwy, but please update your dependencies so that they allow the versions that the current stackage nightly provides.

@Qqwy Qqwy changed the title Adding Qqwy as maintainer of 'vary' and 'symbolize' Adding Qqwy as maintainer of 'vary' Feb 6, 2025
@Qqwy
Copy link
Contributor Author

Qqwy commented Feb 6, 2025

Thank you for enabling the CI!

  • I have removed 'symbolize' for now because it depends on text-display that itself isn't on Stackage yet; I will reach out to their maintainer to see whether they'd want to become curator of that package or not.
  • The too strict bound on QuickCheck for vary has been relaxed.

@alaendle alaendle merged commit 22feabd into commercialhaskell:master Feb 6, 2025
1 check passed
@Qqwy
Copy link
Contributor Author

Qqwy commented Feb 6, 2025

Thank you very much, @alaendle! 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants