Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEC-88] Migrating test data model Inventory Entry #703

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
10 changes: 10 additions & 0 deletions .changeset/metal-mice-sit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
'@commercetools-test-data/inventory-entry': minor
---

Refactored `InventoryEntry` and `InventoryEntryDraft` models to use the new implementation patterns.
This means the existing models are now deprecated (though we still support them for backwards compatibility) and consumers should move to the new ones implemented:
* `InventoryEntryRest`
* `InventoryEntryGraphql`
* `InventoryEntryDraftRest`
* `InventoryEntryDraftGraphql`
98 changes: 0 additions & 98 deletions models/inventory-entry/src/builder.spec.ts

This file was deleted.

12 changes: 0 additions & 12 deletions models/inventory-entry/src/builder.ts

This file was deleted.

114 changes: 114 additions & 0 deletions models/inventory-entry/src/builders.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,114 @@
import {
InventoryEntry,
InventoryEntryRest,
InventoryEntryGraphql,
} from './index';

describe('InventoryEntry model builders', () => {
it('builds a REST model', () => {
const restModel = InventoryEntryRest.random().build();

expect(restModel).toEqual(
expect.objectContaining({
id: expect.any(String),
key: expect.any(String),
version: expect.any(Number),
createdAt: expect.any(String),
createdBy: expect.any(Object),
lastModifiedAt: expect.any(String),
lastModifiedBy: expect.any(Object),
sku: expect.any(String),
quantityOnStock: expect.any(Number),
restockableInDays: expect.any(Number),
availableQuantity: expect.any(Number),
expectedDelivery: expect.any(String),
supplyChannel: expect.any(Object),
custom: null,
})
);
});

it('builds a GraphQL model', () => {
const graphqlModel = InventoryEntryGraphql.random().build();

expect(graphqlModel).toMatchObject(
expect.objectContaining({
id: expect.any(String),
key: expect.any(String),
version: expect.any(Number),
createdAt: expect.any(String),
createdBy: expect.any(Object),
lastModifiedAt: expect.any(String),
lastModifiedBy: expect.any(Object),
sku: expect.any(String),
quantityOnStock: expect.any(Number),
restockableInDays: expect.any(Number),
availableQuantity: expect.any(Number),
expectedDelivery: expect.any(String),
supplyChannel: expect.objectContaining({
__typename: 'Channel',
address: expect.objectContaining({
country: expect.any(String),
}),
}),
supplyChannelRef: expect.objectContaining({
__typename: 'Reference',
id: expect.any(String),
typeId: 'channel',
}),
custom: null,
__typename: 'InventoryEntry',
})
);
});
});

describe('InventoryEntry model compatibility builders', () => {
it('builds a REST model', () => {
const restModel = InventoryEntry.random().buildRest();

expect(restModel).toEqual(
expect.objectContaining({
id: expect.any(String),
key: expect.any(String),
version: expect.any(Number),
createdAt: expect.any(String),
createdBy: expect.any(Object),
lastModifiedAt: expect.any(String),
lastModifiedBy: expect.any(Object),
sku: expect.any(String),
quantityOnStock: expect.any(Number),
restockableInDays: expect.any(Number),
availableQuantity: expect.any(Number),
expectedDelivery: expect.any(String),
supplyChannel: expect.any(Object),
custom: null,
})
);
});

it('builds a GraphQL model', () => {
const graphqlModel = InventoryEntry.random().buildGraphql();

expect(graphqlModel).toMatchObject(
expect.objectContaining({
id: expect.any(String),
key: expect.any(String),
version: expect.any(Number),
createdAt: expect.any(String),
createdBy: expect.any(Object),
lastModifiedAt: expect.any(String),
lastModifiedBy: expect.any(Object),
sku: expect.any(String),
availableQuantity: expect.any(Number),
quantityOnStock: expect.any(Number),
restockableInDays: expect.any(Number),
expectedDelivery: expect.any(String),
supplyChannel: expect.objectContaining({
__typename: 'Channel',
}),
custom: null,
})
);
});
});
42 changes: 42 additions & 0 deletions models/inventory-entry/src/builders.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
import {
createCompatibilityBuilder,
createSpecializedBuilder,
TModelFieldsConfig,
} from '@commercetools-test-data/core';
import { restFieldsConfig, graphqlFieldsConfig } from './fields-config';
import type {
TCreateInventoryEntryBuilder,
TInventoryEntryRest,
TInventoryEntryGraphql,
} from './types';

export const RestModelBuilder: TCreateInventoryEntryBuilder<
TInventoryEntryRest
> = () =>
createSpecializedBuilder({
name: 'InventoryEntryRestBuilder',
type: 'rest',
modelFieldsConfig: restFieldsConfig,
});

export const GraphqlModelBuilder: TCreateInventoryEntryBuilder<
TInventoryEntryGraphql
> = () =>
createSpecializedBuilder({
name: 'InventoryEntryGraphqlBuilder',
type: 'graphql',
modelFieldsConfig: graphqlFieldsConfig,
});

export const CompatInventoryEntryModelBuilder = <
TInventoryEntryModel extends
| TInventoryEntryRest
| TInventoryEntryGraphql = TInventoryEntryRest,
>() =>
createCompatibilityBuilder<TInventoryEntryModel>({
name: 'InventoryEntryCompatBuilder',
modelFieldsConfig: {
rest: restFieldsConfig as TModelFieldsConfig<TInventoryEntryModel>,
graphql: graphqlFieldsConfig as TModelFieldsConfig<TInventoryEntryModel>,
},
});
56 changes: 56 additions & 0 deletions models/inventory-entry/src/fields-config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
import { ChannelGraphql } from '@commercetools-test-data/channel';
import {
ClientLogging,
Reference,
TReferenceGraphql,
} from '@commercetools-test-data/commons';
import {
fake,
sequence,
type TModelFieldsConfig,
} from '@commercetools-test-data/core';
import { createRelatedDates } from '@commercetools-test-data/utils';
import type { TInventoryEntryGraphql, TInventoryEntryRest } from './types';

const [getOlderDate, getNewerDate, getFutureDate] = createRelatedDates();

const commonFieldsConfig = {
id: fake((f) => f.string.uuid()),
version: sequence(),
createdAt: fake(getOlderDate),
createdBy: fake(() => ClientLogging.random()),
lastModifiedAt: fake(getNewerDate),
lastModifiedBy: fake(() => ClientLogging.random()),
key: fake((f) => f.lorem.slug(2)),
sku: fake((f) => f.lorem.words()),
quantityOnStock: fake((f) => f.number.int()),
availableQuantity: fake((f) => f.number.int()),
restockableInDays: fake((f) => f.number.int()),
expectedDelivery: fake(getFutureDate),
custom: null,
};
export const restFieldsConfig: TModelFieldsConfig<TInventoryEntryRest> = {
fields: {
...commonFieldsConfig,
supplyChannel: fake(() => Reference.presets.channelReference()),
},
};
export const graphqlFieldsConfig: TModelFieldsConfig<TInventoryEntryGraphql> = {
fields: {
...commonFieldsConfig,
__typename: 'InventoryEntry',
supplyChannel: fake(() => ChannelGraphql.random()),
supplyChannelRef: fake((f) => Reference.presets.channelReference()),
},
postBuild: (model) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure if I did this part correctly?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

const supplyChannelRef = model.supplyChannel
? Reference.presets
.channelReference()
.id(model.supplyChannel.id)
.buildGraphql<TReferenceGraphql<'channel'>>()
: null;
return {
supplyChannelRef,
};
},
};
29 changes: 0 additions & 29 deletions models/inventory-entry/src/generator.ts

This file was deleted.

25 changes: 23 additions & 2 deletions models/inventory-entry/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,27 @@
import {
RestModelBuilder,
GraphqlModelBuilder,
CompatInventoryEntryModelBuilder,
} from './builders';
import * as modelPresets from './presets';

export * as InventoryEntryDraft from './inventory-entry-draft';
CarlosCortizasCT marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to export the three models with heir own names:

Suggested change
export * as InventoryEntryDraft from './inventory-entry-draft';
export * from './inventory-entry-draft';

export * as InventoryEntry from '.';

export { default as random } from './builder';
export { default as presets } from './presets';
export * from './types';

export const InventoryEntryRest = {
random: RestModelBuilder,
presets: modelPresets.restPresets,
};

export const InventoryEntryGraphql = {
random: GraphqlModelBuilder,
presets: modelPresets.graphqlPresets,
};

/**
* @deprecated Use `InventoryEntryRest` or `InventoryEntryGraphql` exported models instead of `InventoryEntry`.
*/
export const random = CompatInventoryEntryModelBuilder;
export const presets = modelPresets.graphqlPresets;
Loading
Loading