[FEC-38] Fix ProductProjection model reference properties
#638
Conversation
|
CarlosCortizasCT
added
the
fe-chapter-rotation
CarlosCortizasCT
changed the title
ProductProjection model reference propertiesProductProjection model reference properties
| let stateRef: TReferenceGraphql | null = null; | ||
| if (fields.state) { | ||
| const restState = buildField(fields.state, 'rest'); | ||
| stateRef = buildField(fields.state, 'graphql') as TReferenceGraphql; |
There was a problem hiding this comment.
Since the nested model in the default representation holds a Reference, it would be great that we could build the obj property of the reference for the graphql output but we can't build nested properties in isolation and the graphql transformer of the Reference model removes the obj property since it's not part of that representation. So the alternative I found is to build the rest representation and use some its values to create a new graphql model and populate it with it.
Technically this is not 100% right as we would need to overwrite all create graphql instance with the values from the rest one but I can't see a way to do it in a maintainable way.
|
Hey @CarlosCortizasCT, I just finished a fix on the StandalonePrice model transformers. If that can be of any help, let me know |
Hi @nima-ct Thanks for the heads up. It seems the work of your PR is part of what I've done here. |
Description
It all started when migrating some tests in the MC Products application which started to fail when I used the
ProductProjectionmodel.The issue was in this specific function as we are accessing some properties of the
productTypeproperty of the rest representation for theProductProjectionmodel.In the test data models, whenever we need to deal with a reference, we use the
Referencemodel which creates an object with anidandtypeIdproperties by default. Also, in the rest transformers, we create anobjproperty which is supposed to hold the referenced object model but we're creating that one only with its ID and nothing else. That means that, when tests need to access any property of that referenced model, it's not there.First thing I did is to update the
Referencemodel to allow customization of theobjproperty so consumers can actually populate the reference with an actual referenced object.Then I had to update the
ProductProjectionmodel so all references are created with a properobjproperty.After that, I also found another models that were not using references correctly so I needed to update them as well.
Technically speaking this could be a breaking change because we're changing the types of some models properties (specially in the REST version) but I see them more like a fix because the types we were using didn't seem correct.
TODO