Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out UK channel islands #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

booni3
Copy link

@booni3 booni3 commented Oct 23, 2019

The UK Channel islands should be treated differently in regards to tax, to the test of the UK.

  • Exclude Jersey & Guernsey From UK for tax purposes. Jersey and Gurney are part of the UK but are no part of the European Union for VAT purposes

  • Update United Kingdom to show it excludes channel islands & add exclude regex for IM/JE postcodes

  • Add IM postcodes regex

- Exclude Jersey & Guernsey From UK  for tax purposes. Jersey and Gurney are part of the UK but are no part of the European Union for VAT purposes

- Update United Kingdom to show it excludes channel islands & add exclude regex for IM/JE postcodes

- Add IM postcodes regex
"id": "gb_ci_vat_1",
"name": "Jersey",
"country_code": "GB",
"included_postal_codes": "\/(^JE[0-9]{1})\/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need two zone members for Jersey, with a very similar regexp? Can't we just say "JE + a number, anywhere in the string"?

"id": "gb_ci_vat_3",
"name": "Guernsey",
"country_code": "GB",
"included_postal_codes": "\/(^GY[0-9]{1,2})\/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@bojanz
Copy link
Contributor

bojanz commented Oct 23, 2019

Thanks! Left a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants