-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Canadian taxes #31
Conversation
Hello. Just a quick comment here.
Some provinces also collect their own taxes: Quebec as an additional sales taxes (QST or TVQ - Taxe Vente du Quebec) of 9.975% Other provinces either collect no provincial tax ( such as Alberta ) or have their sales taxes Harmonized ( HST ) which means it is the federal government that collects the provincial tax too and redistribute it to the provincial government ( ontario for instance where you have a 13% HST , corresponding to a 5% GST + 8% provincial) Also as business rules:
regards. |
Hey fabienkruba I'll try to update them all. :) |
Rename files so they make sense. Add a test for split-rate (GST/PST)
resources/tax_type/ca_ab_gst.json
Outdated
"name": "Canada - Alberta", | ||
"generic_label": "GST", | ||
"display_inclusive": false, | ||
"zone": "ca_ab_vat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why VAT in the zone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove VAT everywhere in the PR for Canadian Sales Tax as that term is never used in Canada.
resources/tax_type/ca_bc_gst.json
Outdated
"name": "Canada - British Columbia", | ||
"generic_label": "GST", | ||
"display_inclusive": false, | ||
"zone": "ca_bc_vat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove VAT everywhere in the system as that term is never used in Canada.
resources/zone/ca_ns_vat.json
Outdated
@@ -0,0 +1,13 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to rename to remove vat
Remove some unneeded whitespace.
I've updated it with most of the changes mentioned. :) |
"name" => "Manitoba GST", | ||
"generic_label" => "gst", | ||
"tag" => "CA", | ||
"zone" => "ca_mb_vat", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover vat
Will this be merged into master? |
Continued in #73 |
It's based on: http://www.cra-arc.gc.ca/tx/bsnss/tpcs/gst-tps/rts-eng.html