Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Canadian taxes #31

Closed
wants to merge 9 commits into from

Conversation

Archanium
Copy link
Contributor

@fabienkruba
Copy link

Hello. Just a quick comment here.

  • Canada is Tax Exclusive : the prices shown in retail labels is usually before taxes.
  • In this PR it seem you only included the federal part of the taxes. ( GST / Goods and Services Tax of 5%)

Some provinces also collect their own taxes:
https://en.wikipedia.org/wiki/Sales_taxes_in_Canada

Quebec as an additional sales taxes (QST or TVQ - Taxe Vente du Quebec) of 9.975%
Saskachewan 5% of PST ( provincial sales taxes)
Manitoba 8% of PST
British Columbia 7% of PST ( or 10% if liquor.. )

Other provinces either collect no provincial tax ( such as Alberta ) or have their sales taxes Harmonized ( HST ) which means it is the federal government that collects the provincial tax too and redistribute it to the provincial government ( ontario for instance where you have a 13% HST , corresponding to a 5% GST + 8% provincial)

Also as business rules:

  • there are some goods that are tax free ( groceries) , or just eligible to the GST ( some books in quebec are GST only, but not when there is a CD/DVD binded to it for instance)
  • canadian receipts should also display the tax collector number of the company/store. When provinces also collect directly their own share you should display federal and provincial tax collection numbers)
  • receipts should show the split of the 2 taxes
    http://i44.tinypic.com/f087y9.jpg this is a sample of receipt from ontario ( before they switch to the HST )
    https://www.ietf.org/mail-archive/web/81attendees/current/jpgeHqPMf1SRj.jpg this is a sample of restaurant recepit in Quebec ( do not mind the barcode block, this is specific to quebec fiscal printing that uses a special device to generate those)

regards.

@Archanium
Copy link
Contributor Author

Hey fabienkruba

I'll try to update them all. :)
Thanks for the information!

Rename files so they make sense.
Add a test for split-rate (GST/PST)
"name": "Canada - Alberta",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_ab_vat",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why VAT in the zone?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the PR for Canadian Sales Tax as that term is never used in Canada.

@joelpittet joelpittet mentioned this pull request Jan 10, 2016
"name": "Canada - British Columbia",
"generic_label": "GST",
"display_inclusive": false,
"zone": "ca_bc_vat",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove VAT everywhere in the system as that term is never used in Canada.

@@ -0,0 +1,13 @@
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to rename to remove vat

@Archanium
Copy link
Contributor Author

I've updated it with most of the changes mentioned. :)

"name" => "Manitoba GST",
"generic_label" => "gst",
"tag" => "CA",
"zone" => "ca_mb_vat",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover vat

@ftrudeau ftrudeau mentioned this pull request May 7, 2018
@dmitriy-01
Copy link

Will this be merged into master?

@bojanz
Copy link
Contributor

bojanz commented Jan 13, 2020

Continued in #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants