Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom label #4940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MaraScott
Copy link

No description provided.

@MaraScott
Copy link
Author

this is related to that pull-request Comfy-Org/ComfyUI_frontend#849

@Amorano
Copy link

Amorano commented Sep 16, 2024

This should be defined on the field it modifies, not added to another Class attribute.

The "return" types should just be a meta field inside the INPUT_TYPES definition which really should be "NODE_DEFINITION".

I would be 100% behind and supportive of a movement to fix the core design problem so that any future "metadata you want to manipulate in the UX layer" is a no brainer with a simple adding of any field you want to the widget define, RETURN fields included.

    @classmethod
    def NODE_DEFINE(cls) -> dict:
        return {
            "required": {},
            "optional": {},
            "return": {},
            "hidden": {}
        }

I am not sure how to get there from here given the current movement of core changes, but I really do not feel adding this gives any benefit in the long run versus just re-wiring the core to remove any future question about custom metadata in custom nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants