Make default hash lib configurable without code changes via CLI argument #3947
Commits on Jul 4, 2024
-
-
server.py: compare_image_hash configurable hash function
Uses an argument added in cli_args to specify the type of hashing to default to for duplicate hash checking. Uses an `eval()` to identify the specific hashlib class to utilize, but ultimately safely operates because we have specific options and only those options/choices in the arg parser. So we don't have any unsafe input there.
-
-
-
default-hashing-function instead of dupe checking hasher
This makes a default-hashing-function option instead of previous selected option.
-
Commits on Jul 16, 2024
-
Use safer handling for node_helpers.hasher()
Uses a safer handling method than `eval` to evaluate default hashing function.
-
-
Somehow when I hit save I didn't notice I missed a space to make indentation work proper. Oops!
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.