Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "score" as a supported model_type #2918

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ya0guang
Copy link

Originally, "score" is not an allowed model type. However, the documentation supports "score" and the method has code related to it. This commit adds it back.

Originally, `"score"` is not an allowed model type. However, the documentation supports `"score"` and the method has code related to it. This commit adds it back.
@mcmonkey4eva
Copy link
Contributor

mcmonkey4eva commented Sep 24, 2024

While this code change looks technically correct in and of itself - in actual practice, model_type is always exactly noise, and there is no option to change this in native code.

I marked "Good PR" to give @comfyanonymous final choice on whether to pull or reject. The change is valid, code is correct, "score" is a valid supported model_type input except for this mistaken assert. So it makes code "more correct" but has no actual functional effect. Despite being 7 months old, this PR still applies the same to current comfy code.

@mcmonkey4eva mcmonkey4eva added the Good PR This PR looks good to go, it needs comfy's final review. label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good PR This PR looks good to go, it needs comfy's final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants