Add testQuick command for selective test execution
#6553
+666
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the `testQuick` command that only runs tests affected by code changes, using bytecode callgraph analysis to detect which test classes need to re-run. Also re-runs previously failed tests even without code changes. Fixes the JUnit 4 bug where failed tests weren't re-run because JUnit reports fullyQualifiedName as "class.method" while discoveredTestClasses returns just "class". Fixes com-lihaoyi#4109 Co-Authored-By: Claude Opus 4.5 <[email protected]>
The `testQuick` feature adds `runner.codesig` as a dependency of `libs.javalib`, which brings ASM and changes dependency scopes in the Mill build classpath. This updates the golden files to reflect the new dependencies. Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add multi-module integration test (bar → foo dependency tracking) - Add Scala module integration test (qux with uTest) - Add Java example in example/javalib/testing/8-test-quick - Add Scala example in example/scalalib/testing/8-test-quick - Update javalib and scalalib testing.adoc with testQuick documentation Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add try-catch around JSON parsing with graceful fallback to running all tests - Add safeWriteState helper for file write operations with error logging - Add error handling for test artifact cleanup This prevents cryptic crashes when state files are corrupted and provides informative messages to users when I/O operations fail. Co-Authored-By: Claude Opus 4.5 <[email protected]>
The testQuick feature adds runner.codesig as a dependency, which brings additional jars to the build classpath. This updates the golden test to include the new jars: - mill-core-internal-cli_3-SNAPSHOT.jar - mill-core-internal_3-SNAPSHOT.jar - mill-runner-codesig_3-SNAPSHOT.jar Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
testQuickcommand that uses bytecode callgraph analysis to run only tests affected by code changesfullyQualifiedNameincludes method name ("class.method" vs "class")Fixes #4109
Test plan
barmodule trigger tests in dependentfoo.testexample/javalib/testing/8-test-quickexample/scalalib/testing/8-test-quickDocumentation
testQuicksection tojavalib/testing.adoctestQuicksection toscalalib/testing.adoc