-
-
Notifications
You must be signed in to change notification settings - Fork 428
Convert ./mill init to generate .mill.yaml format, add !append support
#6441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+2,188
−3,338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c8663c to
98c2dc9
Compare
Member
|
Is the YAML renderer an addition to the Scala renderer, or do we loose the latter? Asking, since IMHO we should keep the Scala renderer, e.g. to later also convert YAML projects to Scala projects, in case, users need more customizations. |
d7dd4f5 to
aa73d4e
Compare
369e9d9 to
0008407
Compare
19b9f43 to
74671cd
Compare
8b54547 to
6c0e912
Compare
467e038 to
05f6a9c
Compare
b2435f7 to
c3be491
Compare
1eff4bb to
8e519e4
Compare
c4284b5 to
b4d5569
Compare
./mill init to generate .mill.yaml format./mill init to generate .mill.yaml format, add !append support
55eea4e to
94bea2a
Compare
Member
Author
|
Going to merge this first, there's some unresolved breakage that we'll have to look into post-merge. CC @ajaychandran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We generate
.mill.yamlfiles when importing Java projects using./mill init.We still generate Scala code in
mill-build/src/, which lets us avoid duplication in the.mill.yamlfiles since the yaml files canextendthe sharedtraitcontaining the common configScala project import makes use of cross values which are currently not supported in
.mill.yamlso we leave those as generating.millfiles for now.You can now tag top-level YAML values with
!append, which concatenates the Seq the overridden value rather than completely replacing it. This is necessary for.mill.yamlJava project import to work, as we make use ofsuper ++in some places. This is implemented viaparseYaml0converting the!appendtags into a synthetic{"$millAppend": ...}wrapper, which is then deserialized into anAppendable[T]that lets us decide later on whether to append something or notThe
!appendstuff is mentioned in some updated doc examples which demonstrate and exercise it