Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out page-version switcher for global version switcher #3852

Merged
merged 4 commits into from
Oct 27, 2024

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Oct 27, 2024

Previously we disabled the global one because it was redundant, but it seems the page version switcher doesn't play well with renamed pages even when page aliases are defined, resulting in a lot of page version links being broken. So for now we just disable the page version switcher in favor of the global one

Tested locally using docs.githubPages. The link to 0.11.12 is still broken, but it should be fixed once we release 0.11.13 with c61d1ed included

@lihaoyi lihaoyi merged commit 6c7563c into com-lihaoyi:main Oct 27, 2024
24 checks passed
@lefou lefou added this to the 0.12.2 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants