Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coursier to 2.1.11, disable coursier retries #3505

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Sep 10, 2024

Fixes #3465

@alexarchambault
Copy link
Contributor Author

About disabling the retries: there's still a chance some cases aren't handled by coursier/coursier#3066 (the retry in case of download error is pretty large in particular) or that errors aren't caught at the right place in it. But I should be around in the near future, so I can fix things swiftly in coursier if we see such errors again.

@lihaoyi
Copy link
Member

lihaoyi commented Sep 10, 2024

Looks good to me. We'll have to see how stable it is post merge, but we can fix any further flakiness as we encounter it

@lihaoyi lihaoyi merged commit 649eb5f into com-lihaoyi:main Sep 10, 2024
23 checks passed
@lefou lefou added this to the 0.12.0 milestone Sep 10, 2024
@alexarchambault alexarchambault deleted the bump-coursier branch September 10, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mill parallelism is not stable on windows
3 participants