Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby downloader #77

Closed
wants to merge 29 commits into from
Closed

Ruby downloader #77

wants to merge 29 commits into from

Conversation

agross
Copy link

@agross agross commented Mar 14, 2016

  1. Pure ruby downloader
  2. Extract zip using rubyzip
  3. Use gem version to download binaries (2.1.1.42 -> 2.1.1)
  4. Supports Windows x64
  5. Removed the /tmp cleaning workaround and use proper Dir.mktmpdir
  6. The call to which is replaced by a pure ruby implementation
  7. Refactorings

Additional changes:

  1. rspec 3.4 with expect syntax
  2. Use bundler caching on Travis

Relates to #76.

@agross
Update gem information and development dependencies
88775c4
@agross
Use rubyzip to extract zip files, as unzip is likely not installed on…
37cd46d 
… Windows
@agross
Support Windows x64
350b465
@agross
Downloading the same phantomjs version as the gem version
19d6063
@agross
Use Dir.mktmpdir instead of manually creating and cleaning the downlo…
71b5441 
…ad directory
@agross
Refactoring
651b5ff
@agross
Download using Ruby with percentage
df24d98
@agross
Fix missing parenthesis
a50ed94
@agross
Run travis on linux and OSX
76a544d
@agross
Remove Ruby 1.9 from travis builds as mime-types-data requires Ruby >…
d2a0962 
…= 2.0
@agross
Use multi-platform which implementation
a17c434
@agross
Log download URL
7e32baa
@agross
On Windows, define phantomjs.exe as the executable
fa32364
@agross
Fix phantomjs runner spec for phantomjs 2.0
e2a0092
@agross
Fix specs
81cd034
@agross
rspec 3 syntax
c2ff828
@agross
Make sure phantomjs is executable
70caca9
@agross
Remove info about cURL, wget and unzip from readme
3f62377
@agross
Exclude Ruby 2.2 from MacOS build
f810b46
@agross
Report errors for bunzip2 and tar
5d74626
@agross
Platform#temp_path is no longer needed
6ebe3a3
@agross
Use version that works on MacOS El Capitan
2b12601
@agross
Add note about WebMock, closes #1
83bd604
@agross
Update to 2.1.1
8b82bc9
@agross
Tweak Travis configuration to use more Rubies and caching
a567b5f
@agross
Add download retry
3017182
@agross
Work around Net::HTTP errors on Ruby 1.9
6f8629b
@agross
Do not verify SSL certificates on Windows only (where CAcerts are gen…
2bd661f 
…erally unavailable unless the user manually downloads them)
@agross
Exclude failing Travis builds and be more specific about Ruby 2.2
1238ab0
@GregOnNet
Copy link

Hi,

it would be nice if this pull request is going to be merged in the near future.
I personally depend on the fixes made here.

Kinds
Greg

@agross agross closed this Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agross @GregOnNet