Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fragile buildscript #50

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Fix fragile buildscript #50

merged 1 commit into from
Jun 27, 2017

Conversation

AnrDaemon
Copy link
Contributor

Use absolute paths.
Added quoting to shield against unsafe characters in CLASSPATH and parameters.

@AnrDaemon
Fix fragile buildscript
77ccbd4 
Use absolute paths.
Added quoting to shield against unsafe characters in CLASSPATH and parameters.
@AnrDaemon
Copy link
Contributor Author

Not all implementations of /bin/sh support same-line assignment on export.
And using foreign variables unquoted is not safe, even on Linux.
On Windows, it's worse. I'm leaning to the suggestion of eliminating the windows build script. It is extremely fragile due to the nature of CMD and essentially unfixable without a lot of trickery.

@ctapmex ctapmex merged commit 4056d27 into colorer:master Jun 27, 2017
@ctapmex
Copy link
Member

ctapmex commented Jun 27, 2017

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnrDaemon @ctapmex