[Gamut Mapping App] Always display delta #458
Conversation
✅ Deploy Preview for colorjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jamesnw
changed the title
|
I like this. |
As I mentioned in the other PR, gamut mapping should never change in-gamut colors. When this happens, it's a bug. |
@LeaVerou Even if that's correct (and this comment makes it sound like not everyone agrees with that), isn't it helpful to surface it? |
That was my thinking. It isn't that gamut mapping should alter already in gamuts, but it lets you see whether they are. |
|
I don’t have a very strong opinion, but it seems to me that it's a bigger UI distinction to not show deltas when they're 0. It goes through the image processing circuit of your brain, whether displaying them but having them be 0 requires you to read and process the numbers to understand that the color is the same. That said, @svgeesus brought up a very good point about certain GMA that affect colors near the gamut boundary. So my weakly held opinion is that we should show deltas iff the color is different than the original (whether or not they are in gamut). We could potentially get the best of both worlds by displaying the deltas but fading them out. |
I think that would be a fine alternative. It solves the original concern but also filters out the useless noise. |
|
I like that as an alternative, and @jgerigmeyer has offered to implement. Thanks! |
* main: Audit function parameter and return types (2/2) (#457) Always show delta display to help confirm it is in gamut (#458) Final clip is required in Ray tracing [apps/gamut-mapping] Add edge seeker algorithm (#448) Audit function parameter and return types (1/2) (#456) Rework raytracing limiting hue shift to no more than 3 degrees at worst
See conversation at #438 (comment).
The result of a gamut mapping algorithm may change in-gamut colors, so it is useful to see the deltas in those cases as well.