-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made a proof-of-concept of option №2 from #496 #518
Closed
DandelionSprout
wants to merge
1,306
commits into
collinbarrett:master
from
DandelionSprout:patch-31
Closed
Made a proof-of-concept of option №2 from #496 #518
DandelionSprout
wants to merge
1,306
commits into
collinbarrett:master
from
DandelionSprout:patch-31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuesday daytime pull, incl. 12 new lists
on line 10950 of collinbarrett#433 ...and other minor cleanup
Tuesday afternoon pull
Monday morning pull, take 2
Tuesday night pull
Wednesday afternoon pull
Nice. Thanks for this. I still kinda like this option, but not sure yet... |
collinbarrett
added
needs work
needs additional work
blocked
blocked by another issue
labels
Sep 26, 2018
This pull request seems to have become a bit messed up since it was originally made, so I think it's just as well to just close this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
blocked by another issue
directory-data
changes to basic FilterLists data
needs work
needs additional work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I see that option №3 in #496 seems to be slightly preferred at the moment, I decided to make a test showcase of how option №2 could've looked like if it was put into use.
This pull is almost guaranteedly not fit to be merged in its current state; feel free to reject it or to build on its foundation as you see fit.