Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a proof-of-concept of option №2 from #496 #518

Closed
wants to merge 1,306 commits into from

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Sep 26, 2018

While I see that option №3 in #496 seems to be slightly preferred at the moment, I decided to make a test showcase of how option №2 could've looked like if it was put into use.

This pull is almost guaranteedly not fit to be merged in its current state; feel free to reject it or to build on its foundation as you see fit.

collinbarrett and others added 30 commits September 3, 2018 17:28
Tuesday daytime pull, incl. 12 new lists
on line 10950 of collinbarrett#433
...and other minor cleanup
@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Sep 26, 2018
@collinbarrett
Copy link
Owner

Nice. Thanks for this. I still kinda like this option, but not sure yet...

@collinbarrett collinbarrett added needs work needs additional work blocked blocked by another issue labels Sep 26, 2018
@DandelionSprout
Copy link
Contributor Author

This pull request seems to have become a bit messed up since it was originally made, so I think it's just as well to just close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked blocked by another issue directory-data changes to basic FilterLists data needs work needs additional work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants