Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

April pull #3500

Merged
merged 12 commits into from
Apr 4, 2023
Merged

April pull #3500

merged 12 commits into from
Apr 4, 2023

Conversation

DandelionSprout
Copy link
Contributor

@DandelionSprout DandelionSprout commented Apr 3, 2023

• Added 6 lists.
• Added a whole bunch of language tags to various lists, based in part on https://github.com/DandelionSprout/adfilt/blob/master/Wiki/Status%20for%20rare%20languages.md
• Added Papiamento as a language option.
• Fixed 1 case of what looked like a duplicate ID in FilterListViewUrl.json.

@collinbarrett
Copy link
Owner

Seeing this in the build failure log:

System.InvalidOperationException: The seed entity for entity type 'FilterListSyntax' cannot be added because another seed entity with the key value 'FilterListId:2651, SyntaxId:3' has already been added.

@collinbarrett collinbarrett added the directory-data changes to basic FilterLists data label Apr 3, 2023
@DandelionSprout
Copy link
Contributor Author

The error message seemed to be onto something, so I've tried to fix it now.

},
{
"id": 181,
"iso6391": "pap",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest build error is complaining that pap is three characters when the database only expects two.

It looks like pap isn't an ISO 639-1 code, but rather an ISO 639-2 code. I can't seem to find if it has an ISO 639-1 code...

I'm not sure how to move forward... I'm open to changing what code standardization we use on FilterLists if that's better, but that would take some work...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #3502

For now, I would suggest just not adding this language. It looks like it is only being applied to a single list here. Once we figure out a fix for #3502 , we can certainly add the language to that list.

@DandelionSprout
Copy link
Contributor Author

The first thought that comes to mind, is that since there's apparently no languages whose 639-1 codes are pp, that we could simply unofficially shorten pappp.

But this week hasn't been my most awake one, so I suppose I can indeed remove that filterlist language tag for now.

@collinbarrett collinbarrett merged commit c4f46fc into collinbarrett:main Apr 4, 2023
collinbarrett added a commit that referenced this pull request Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
directory-data changes to basic FilterLists data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants