-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
April pull #3500
April pull #3500
Conversation
Seeing this in the build failure log:
|
The error message seemed to be onto something, so I've tried to fix it now. |
}, | ||
{ | ||
"id": 181, | ||
"iso6391": "pap", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest build error is complaining that pap
is three characters when the database only expects two.
It looks like pap
isn't an ISO 639-1 code, but rather an ISO 639-2 code. I can't seem to find if it has an ISO 639-1 code...
I'm not sure how to move forward... I'm open to changing what code standardization we use on FilterLists if that's better, but that would take some work...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first thought that comes to mind, is that since there's apparently no languages whose 639-1 codes are But this week hasn't been my most awake one, so I suppose I can indeed remove that filterlist language tag for now. |
• Added 6 lists.
• Added a whole bunch of language tags to various lists, based in part on https://github.com/DandelionSprout/adfilt/blob/master/Wiki/Status%20for%20rare%20languages.md
• Added Papiamento as a language option.
• Fixed 1 case of what looked like a duplicate ID in
FilterListViewUrl.json
.