Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): support soft-deleting FilterLists #1741

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Conversation

collinbarrett
Copy link
Owner

resolves #713

@collinbarrett collinbarrett marked this pull request as ready for review July 5, 2020 19:24
@collinbarrett
Copy link
Owner Author

collinbarrett commented Jul 5, 2020

Now, by adding a key/value to any entry in FilterList.json as follows, it will be excluded from the website/API but gives us the opportunity to easily re-add later.

"isDeleted": true,

Updated Wiki.

We can easily add this to any other entity (Maintainers, Tags, etc.), but I thought we should just start with the FilterLists themselves and see how it evolves.

FYI, @DandelionSprout ^

@collinbarrett collinbarrett merged commit 20d4492 into master Jul 5, 2020
@collinbarrett collinbarrett deleted the soft-delete branch July 5, 2020 19:29
@DandelionSprout
Copy link
Contributor

Nice to know. It'll probably come in handy sometime within the next month, but I can't give an exact date as to when.

@DandelionSprout
Copy link
Contributor

Although presuming this is primarily meant for #1737 to begin with, it'll be used within 2 weeks.

@gwarser
Copy link
Contributor

gwarser commented Jul 19, 2020

Entries with "isDeleted": true, are dropped from "compressed" FilterList.min.json?


Ah, this: a4a7414 ?

@collinbarrett
Copy link
Owner Author

@gwarser , We don't have a "compressed" FilterList.min.json that I'm aware of. But, this soft delete feature does remove the lists from being shown on the UI which gets its data from this API endpoint. https://filterlists.com/api/v1/lists

@gwarser
Copy link
Contributor

gwarser commented Jul 20, 2020

I meant minified. And yes, I looked into https://filterlists.com/api/v1/lists in attempt to exclude these marked lists from by downloader script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

soft delete
3 participants