Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for > 8 bytes per message in candump format #871

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mvgalen
Copy link

@mvgalen mvgalen commented Nov 29, 2024

I have a candump log with the following data:
(1727438342.368435) can0 0C0 [32] 03 F5 FE E7 FF 10 27 00 E0 FF FF F3 3F FF F3 3F FC EF FF FD FF FF FE 07 00 00 00 00 00 00 00 00
(1727438342.372671) can0 583 [08] 00 00 80 00 10 40 40 40

The current candump parser only looks at the first number after the [ character.

@mvgalen
Copy link
Author

mvgalen commented Dec 3, 2024

Hi @collin80,
Would you please consider this simple pull request? It greatly improves the usability of SavvyCan for CAN-FD loggings in CANdump format. No need to merge the workflow change.
Cheers,
Marijn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant