Remember busspeed #457
Open
Remember busspeed #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing variables in settings
jogo-
reviewed
Mar 19, 2022
| if (portNames.count() != driverNames.count() || devTypes.count() != driverNames.count()) return; | ||
| if (portNames.count() != driverNames.count() || devTypes.count() != driverNames.count() || driverNames.count() != busNums.count()) return; | ||
|
|
||
| // connect tthe bus get/set |
edge90
reviewed
Sep 4, 2024
| conn_p->start(); | ||
|
|
||
| connect(this, SIGNAL(updateBusSpeed(int, int)), conn_p, SLOT(updateBusSpeed(int, int))); |
There was a problem hiding this comment.
connect(this, &ConnectionWindow::updateBusSpeed, conn_p, &CANConnection::updateBusSpeed);
Gives errors during compile time instead of runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #445 .
It's a bit crude but the bus speed update has to take place after initialization of the connection on most devices hence the different update method. The bus speed is only saved if the change was successful in the configuration screen so for some users it might look like nothing is working due to that failing. My familiarity with the QT Threading system is poor at best, maybe this was not the best way to do it but for me it works and it might be of use to others. I have no way to test it with the current supported devices so YMMV with those implementations.
Not tested on Windows/OSX as I have no working setup for those OS's.