Plone 5 (tests OK) #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b23ac41.
The new control panel uses javascript, which zope.testbrowser ignores.
|
Would you add Travis setup to confirm it works both under Plone 4.3 and 5 ? |
gotcha
reviewed
Apr 1, 2019
| if 'summary' in self.context.Schema()['description'].widget.label: | ||
| key = 'summary' | ||
| else: | ||
| key = 'description' |
There was a problem hiding this comment.
We should keep the distinction between description and summary. The description field is still named summary in the "Page" content type.
There was a problem hiding this comment.
It is not the only place where keeping the distinction is needed.
| <td tal:condition="python: field != 'Title' and field not in ['ModificationDate', | ||
| 'CreationDate', 'EffectiveDate', | ||
| 'ExpirationDate', ]" | ||
| tal:content="value" |
There was a problem hiding this comment.
I prefer logic to be kept in view classes. Would it be possible to move this tal:condition test to a method on a view class ?
| tal:attributes="href obj_url; | ||
| title obj_description;"> | ||
| <img class="thumb-icon" | ||
| tal:define="getIcon python:obj.getURL() +'/@@images/image/icon'" |
There was a problem hiding this comment.
python: in the template is often a smell. I would compute the image URL in the view class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is the same PR as #19, with working tests.
At first, I tried to fix the functional tests for the control panel, but the new select widget requires javascript, so I wrote robot tests instead.
zope.testbrowser documentation mentions this, but "zope.testbrowser.real" doesn't seem to exist: