Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for RedisCluster (phpredis extension) #191

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adding support for RedisCluster (phpredis extension) #191

wants to merge 4 commits into from

Conversation

JacobBrownAustin
Copy link

@JacobBrownAustin JacobBrownAustin commented Sep 18, 2024 •
edited
Loading

@JacobBrownAustin JacobBrownAustin mentioned this pull request Sep 18, 2024
Open
@colinmollenhour
Copy link
Owner

Thanks for the PR! I think this should probably just replace Credis_Cluster since it was never completed and would need a lot of work and having both would be confusing. Would you mind removing that, updating the README and add a basic PHPUnit test? Also, I think the constructor should probably throw an exception if the phpredis extension is not present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JacobBrownAustin @colinmollenhour