Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for php 8.3 and php 8.4 #186

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

Xon
Copy link

@Xon Xon commented Mar 22, 2024

No description provided.

Xon added 2 commits March 22, 2024 21:39
… To maintain compatibility with php 7.1 and earlier, remove the type argument
@Xon
Copy link
Author

Xon commented Mar 22, 2024

https://wiki.php.net/rfc/deprecate-implicitly-nullable-types

In a future update for 8.4, the following will produce a deprecated notice which a number of enviroments may turn into a hard error.

function a (array $b = null) {}

Since this project supports older versions of php, removing array type definition fixes this. As changing to ?array requires php 7.1+

@colinmollenhour colinmollenhour merged commit ba53f7e into colinmollenhour:master Apr 2, 2024
6 checks passed
@colinmollenhour
Copy link
Owner

Thanks, @Xon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants