-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise documentation for date format changes #195
base: main
Are you sure you want to change the base?
Conversation
As requested the changes have been applied to this document. The arrangement of the document differs to that output by the Roxygen document (paramater location). Hopefully it still makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect, thanks! Just a few tweaks with spacing / wording I would suggest.
Worth noting that you can "add these as a batch" and bundle into a single commit, which is probably preferable
#' # options( | ||
#' # xlsx.date.format = 'dd/MM/YYYY', | ||
#' # xlsx.datetime.format = 'dd/MM/YYYY HH:mm:ss' | ||
#' #) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#' #) | |
#' # ) |
@@ -18,6 +18,11 @@ | |||
#' They need to be specified in Java date format | |||
#' \url{https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html}. | |||
#' | |||
#'Changes to the xlsx date/time formats need to be passed to the R session using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#'Changes to the xlsx date/time formats need to be passed to the R session using the | |
#' Changes to the xlsx date/time formats need to be passed to the R session using the |
@@ -18,6 +18,11 @@ | |||
#' They need to be specified in Java date format | |||
#' \url{https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html}. | |||
#' | |||
#'Changes to the xlsx date/time formats need to be passed to the R session using the | |||
#'R session function \code{option()} not as an xlsx package parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#'R session function \code{option()} not as an xlsx package parameter. | |
#' \code{options()} function, not as an xlsx package parameter. |
#'Changes to the xlsx date/time formats need to be passed to the R session using the | ||
#'R session function \code{option()} not as an xlsx package parameter. | ||
#' | ||
#'An example of this syntax is shown below as a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#'An example of this syntax is shown below as a comment. | |
#' An example of this syntax is shown below as a comment. |
As requested the changes have been applied to this document. The arrangement of the document differs to that output by the Roxygen document (paramater location). Hopefully it still makes sense.
this is linked to PR #194