-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add P402 as Facilitator #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🟡 Heimdall Review Status
|
|
@Z333Q is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @Z333Q, thanks for your submission!
|
|
Thanks @phdargen! I have addressed all feedback: |
Z333Q
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify commit
|
Also /supported is still returning '404' and I tested the facilitator with an endpoint and it returned HTTP 200 but:
|
8127ffa to
f9d16d9
Compare
f9d16d9 to
e1f4b26
Compare
| "verify": true, | ||
| "settle": true, | ||
| "supported": true, | ||
| "list": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems there is no discovery endpoint live, please set list to false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phdargen done.
"list": false
|
Hi @Z333Q, tested your facilitator with this example on base mainnet: https://github.com/coinbase/x402/tree/main/examples/typescript/servers/express Also your supported endpoint shows |
Hi @phdargen, thanks for testing! Both issues have been fixed:
We've added x402-compliant top-level route handlers:
Response shapes match the x402 core types (VerifyResponse, SettleResponse, We also fixed an internal env var inconsistency where the settlement service |




Description
Tests
Checklist