Skip to content

fix: select payment requirements in MCP wrapper #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarsonRoscoe merged 4 commits into from
Feb 9, 2026
Merged

fix: select payment requirements in MCP wrapper #1130

CarsonRoscoe merged 4 commits into from
Feb 9, 2026
+28 −4

Conversation

@CarsonRoscoe
Copy link
Contributor

@CarsonRoscoe CarsonRoscoe commented Feb 9, 2026 •
edited
Loading

Description

  1. Fixed a bug with selecting payment requirements
  2. Loosened OptionalAny definition to allow nullable. Required for interopability with Add MCP submodule to Python SDK #1131

Tests

Fixed unit tests accordingly

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits
  • I added a changelog fragment for user-facing changes (docs-only changes can skip)

@cb-heimdall
Copy link

cb-heimdall commented Feb 9, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Feb 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
x402 Ready Ready Preview, Comment Feb 9, 2026 1:37pm

Request Review

@github-actions github-actions bot added typescript sdk Changes to core v2 packages labels Feb 9, 2026
@CarsonRoscoe CarsonRoscoe marked this pull request as ready for review February 9, 2026 13:36
@CarsonRoscoe CarsonRoscoe mentioned this pull request Feb 9, 2026
Closed
4 tasks
avidreder
avidreder approved these changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@avidreder avidreder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarsonRoscoe CarsonRoscoe merged commit 9ec9f15 into main Feb 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avidreder avidreder avidreder approved these changes

Assignees

No one assigned

Labels

sdk Changes to core v2 packages typescript

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarsonRoscoe @cb-heimdall @avidreder