fix(python): camelCase serialization + auto-wrap LocalAccount#1122
Open
madisoncarter1234 wants to merge 3 commits intocoinbase:mainfrom
Open
fix(python): camelCase serialization + auto-wrap LocalAccount#1122madisoncarter1234 wants to merge 3 commits intocoinbase:mainfrom
madisoncarter1234 wants to merge 3 commits intocoinbase:mainfrom
Conversation
🟡 Heimdall Review Status
|
|
@madisoncarter1234 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Two fixes for the Python SDK: 1. Add serialize_by_alias=True to BaseX402Model so model_dump_json() produces spec-compliant camelCase by default. Users no longer need to pass by_alias=True manually. (Fixes coinbase#1120) 2. Auto-wrap eth_account LocalAccount in EthAccountSigner when passed to ExactEvmScheme or ExactEvmSchemeV1. This prevents the confusing ValueError from mismatched sign_typed_data signatures. (Fixes coinbase#1121)
madisoncarter1234
force-pushed
the
fix/auto-wrap-local-account
branch
from
a38c411 to
0ce1d36
Compare
The "should create default client if empty array provided" test was calling initialize() on a server with a real HTTPFacilitatorClient, causing a network request that timed out on Node 22 in CI. The test only needs to verify that the constructor accepts an empty array, not that initialize works with a real facilitator. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serialize_by_alias=TruetoBaseX402Model.model_configsomodel_dump_json()produces spec-compliant camelCase (x402Version,payTo,maxTimeoutSeconds) by default — users no longer need to passby_alias=Truemanuallyeth_account.LocalAccountinEthAccountSignerwhen passed toExactEvmSchemeorExactEvmSchemeV1, preventing the confusingValueErrorfrom mismatchedsign_typed_datasignaturesFixes #1120
Fixes #1121
Test plan