Merged
Conversation
haoruikun-cb
commented
Feb 11, 2026
cb-ekuersch
reviewed
Feb 11, 2026
| AnnouncementBarProvider, | ||
| ScrollControllerProvider, | ||
| DocsPreferredVersionContextProvider, | ||
| // TODO: Docusaurus uses @types/react 18 (no bigint in ReactNode) while workspace uses React 19. |
Contributor
There was a problem hiding this comment.
@haoruikun-cb did you look into if we can upgrade to a docusarous version that support 19 types?
cb-ekuersch
reviewed
Feb 11, 2026
| @@ -1,4 +1,4 @@ | |||
| import React, { useState, type JSX } from 'react'; | |||
| import React, { type JSX,useState } from 'react'; | |||
cb-ekuersch
reviewed
Feb 11, 2026
| @@ -1,4 +1,4 @@ | |||
| import React, { useState, type JSX } from 'react'; | |||
| import React, { type JSX,useState } from 'react'; | |||
cb-ekuersch
reviewed
Feb 11, 2026
| @@ -1,4 +1,4 @@ | |||
| import React, { type ReactNode, useCallback, useState, type JSX } from 'react'; | |||
| import React, { type JSX,type ReactNode, useCallback, useState } from 'react'; | |||
cb-ekuersch
reviewed
Feb 11, 2026
| @@ -1,4 +1,4 @@ | |||
| import { useMemo, type JSX } from 'react'; | |||
| import { type JSX,useMemo } from 'react'; | |||
cb-ekuersch
reviewed
Feb 11, 2026
| @@ -1,4 +1,4 @@ | |||
| import React, { memo, useCallback, useEffect, useMemo, useRef, useState, type JSX } from 'react'; | |||
| import React, { type JSX,memo, useCallback, useEffect, useMemo, useRef, useState } from 'react'; | |||
cb-ekuersch
reviewed
Feb 11, 2026
Contributor
cb-ekuersch
left a comment
cb-ekuersch
left a comment
There was a problem hiding this comment.
it would be great if docusarous has a version that supports react 19 types - lets check and see!
cb-ekuersch
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Fixed lint and type check issues in cds-v9 branch
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false