fix: address the misbehaving negative margin issue for Banner#383
Merged
haoruikun-cb merged 3 commits intomasterfrom Feb 10, 2026
Merged
fix: address the misbehaving negative margin issue for Banner#383haoruikun-cb merged 3 commits intomasterfrom
haoruikun-cb merged 3 commits intomasterfrom
Conversation
Collaborator
✅ Heimdall Review Status
✅
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
✅
1/1
|
Denominator calculation
|
haoruikun-cb
had a problem deploying
to
production
GitHub Actions
Error
hcopp
reviewed
Feb 9, 2026
| styleVariant="contextual" | ||
| title="Bleeding banner" | ||
| variant="informational" | ||
| width="calc(100% + var(--space-4))" |
Contributor
There was a problem hiding this comment.
Can we do width="auto"? That should work for most cases
haoruikun-cb
temporarily deployed
to
production
GitHub Actions
Inactive
hcopp
reviewed
Feb 10, 2026
Contributor
hcopp
left a comment
hcopp
left a comment
There was a problem hiding this comment.
Code changes look great to me. We can wait for @maximo-macchi-cb tomorrow since he started the discussion initially.
haoruikun-cb
temporarily deployed
to
production
GitHub Actions
Inactive
haoruikun-cb
force-pushed
the
harry/banner-margin-fix
branch
from
d1e28ee to
a134710
Compare
…w customer to override the widht
haoruikun-cb
force-pushed
the
harry/banner-margin-fix
branch
from
a134710 to
041e509
Compare
haoruikun-cb
temporarily deployed
to
production
GitHub Actions
Inactive
maximo-macchi-cb
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…w customer to override the widht
What changed? Why?
Root cause (required for bugfixes)
UI changes
Testing
How has it been tested?
Testing instructions
Illustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false