feat: add open/close visibility delays to Tooltip #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
sverg-cb
force-pushed
the
sverg/tooltip-delay
branch
from
613a757 to
76e2ca6
Compare
sverg-cb
force-pushed
the
sverg/tooltip-delay
branch
from
76e2ca6 to
4bf9db3
Compare
Contributor
haoruikun-cb
left a comment
haoruikun-cb
left a comment
There was a problem hiding this comment.
Great work. My suggestion on the xxDelay != null can be applied to multiple places.
| }); | ||
| }; | ||
|
|
||
| if (closeDelay != null && closeDelay > 0) { |
Contributor
There was a problem hiding this comment.
nit: it could be
Suggested change
| if (closeDelay != null && closeDelay > 0) { | |
| if (closeDelay && closeDelay > 0) { |
| }; | ||
|
|
||
| clearOpenTimeout(); | ||
| if (openDelay != null && openDelay > 0) { |
Contributor
There was a problem hiding this comment.
same suggestion as above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Tooltip:openDelayandcloseDelayRoot cause (required for bugfixes)UI changes
iOS
Screen.Recording.2026-02-10.at.11.56.04.AM.mov
Web
Screen.Recording.2026-02-10.at.11.56.50.AM.mov
Testing
How has it been tested?
Testing instructions
yarn nx dev storybookoryarn nx dev docsIllustrations/Icons Checklist
Required if this PR changes files under
packages/illustrations/**orpackages/icons/**Change management
type=routine
risk=low
impact=sev5
automerge=false