fix: PROSPER connector doesn't recover from failure after network issue#328
Open
mohammad-arif662 wants to merge 4 commits intomainfrom
Open
fix: PROSPER connector doesn't recover from failure after network issue#328mohammad-arif662 wants to merge 4 commits intomainfrom
mohammad-arif662 wants to merge 4 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
==========================================
+ Coverage 75.48% 76.09% +0.61%
==========================================
Files 38 38
Lines 4083 4083
Branches 487 488 +1
==========================================
+ Hits 3082 3107 +25
+ Misses 817 792 -25
Partials 184 184
🚀 New features to boost your workflow:
|
Collaborator
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a potential stability issue by changing the PublishConnectorStatus method from async void to async Task. This prevents unhandled exceptions from crashing the application and allows for proper error propagation. My review includes a few suggestions to align the naming of this asynchronous method with the project's style guide by adding the Async suffix. Overall, this is a solid and important fix.
abdullah-cognite
requested changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a simulation was running and the system lost internet connectivity, the connector would terminate unexpectedly, leaving the run stuck in "running" status indefinitely. It happens because
PublishConnectorStatuswas declared asasync void, which cannot be awaited by the caller and causes unhandled exception typeHttpRequestExceptionto crash the process.Fix
Changed
PublishConnectorStatusfromasync voidtoasync Taskand added proper await calls. Now network exceptions propagate to the outer try/catch block which allows the connector to continue running and recover when connectivity is restored and marks the run as "failure".