Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a lobby + fix multiuser joining + instruction for deploying using a tunnelling system #109

Merged
merged 5 commits into from
Dec 7, 2022

Conversation

cloderic
Copy link
Member

@cloderic cloderic commented Nov 28, 2022

closes #101

@cloderic cloderic self-assigned this Nov 28, 2022
@cloderic cloderic changed the base branch from main to next November 28, 2022 01:06
@cloderic cloderic changed the title Introduce a lobby + fix multiuser joining Introduce a lobby + fix multiuser joining + instruction for deploying using a tunnelling system Nov 29, 2022
@cloderic cloderic requested review from wduguay-air and lhnguyen102 and removed request for saikrishna-1996 and lhnguyen102 November 29, 2022 15:40
wduguay-air
wduguay-air previously approved these changes Dec 6, 2022
Copy link
Contributor

@wduguay-air wduguay-air left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multiplayer implementation in jsx is a bit over my head I must say.

cogment_verse/app.py Show resolved Hide resolved
cogment_verse/processes/web.py Outdated Show resolved Hide resolved
cogment_verse/web/web_app/src/index.tsx Show resolved Hide resolved
wduguay-air
wduguay-air previously approved these changes Dec 6, 2022
@cloderic cloderic merged commit 6a166a1 into next Dec 7, 2022
@cloderic cloderic deleted the simple_match_making branch December 7, 2022 15:18
cloderic added a commit that referenced this pull request Jan 24, 2023
… using a tunnelling system (#109)

* Fix missing constructor parameters

* Introduce a trial lobby

* Fix copyright notices

* Adding documentation for ngrok based tunnel

* Take into account review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants