-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a lobby + fix multiuser joining + instruction for deploying using a tunnelling system #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloderic
changed the title
Introduce a lobby + fix multiuser joining
Introduce a lobby + fix multiuser joining + instruction for deploying using a tunnelling system
Nov 29, 2022
cloderic
requested review from
wduguay-air and
lhnguyen102
and removed request for
saikrishna-1996 and
lhnguyen102
November 29, 2022 15:40
wduguay-air
previously approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The multiplayer implementation in jsx is a bit over my head I must say.
wduguay-air
previously approved these changes
Dec 6, 2022
cloderic
force-pushed
the
simple_match_making
branch
from
December 6, 2022 19:10
985aeb2
to
c5550ce
Compare
wduguay-air
approved these changes
Dec 7, 2022
cloderic
added a commit
that referenced
this pull request
Jan 24, 2023
… using a tunnelling system (#109) * Fix missing constructor parameters * Introduce a trial lobby * Fix copyright notices * Adding documentation for ngrok based tunnel * Take into account review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #101