expand xarray capabilities #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsarago
commented
Oct 24, 2024
| @@ -118,7 +120,7 @@ def info(self) -> Info: | |||
|
|
|||
| meta = { | |||
| "bounds": self.bounds, | |||
| "crs": CRS_to_uri(self.crs), | |||
| "crs": CRS_to_uri(self.crs) or self.crs.to_wkt(), | |||
There was a problem hiding this comment.
match what we do in io.rasterio.Reader
7 tasks
vincentsarago
commented
Oct 24, 2024
| "attrs": { | ||
| k: (v.tolist() if isinstance(v, (numpy.ndarray, numpy.generic)) else v) | ||
| for k, v in self.input.attrs.items() | ||
| }, |
There was a problem hiding this comment.
There was a possible issue in titiler where pydantic wouldn't be able to serialize the attrs because pydantic do not handle well numpy arrays
vincentsarago
commented
Oct 24, 2024
| height=height, | ||
| reproject_method=reproject_method, | ||
| resampling_method=resampling_method, | ||
| ) |
There was a problem hiding this comment.
feature() now use part() method (as we do in io.rasterio.Reader)
vincentsarago
commented
Oct 24, 2024
| assert info | ||
| assert info.model_dump() | ||
| assert info.model_dump(mode="json") | ||
| assert info.model_dump_json() |
There was a problem hiding this comment.
test pydantic serialization
vincentsarago
commented
Oct 25, 2024
| self.bounds[0] + xres / 2 < -180 | ||
| or self.bounds[1] + yres / 2 < -90 | ||
| or self.bounds[2] - xres / 2 > 180 | ||
| or self.bounds[3] - yres / 2 > 90 | ||
| ): |
There was a problem hiding this comment.
cc @noahgolmant
closes #754
…756) * check if the Y bounds are inverted and flip the image on the Y axis * Update tests/test_io_xarray.py Co-authored-by: Henry Rodman <[email protected]> * Update tests/test_io_xarray.py Co-authored-by: Henry Rodman <[email protected]> --------- Co-authored-by: Henry Rodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
preview()andstatistics()method to the XarrayReaderpreview,partandfeaturemethodscc @abarciauskas-bgse @maxrjones @hrodmn
To Do